New Draw State Terminology #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
PierrickGT
approved these changes
Jun 30, 2023
src/PrizePool.sol
Outdated
| /// @notice Returns the start time of the draw for the next successful completeAndStartNextDraw | ||
| function _nextDrawStartsAt() internal view returns (uint64) { | ||
| return _nextDrawEndsAt() - drawPeriodSeconds; | ||
| /// @notice Returns the start time of the draw for the next successful closeAndStartNextDraw |
There was a problem hiding this comment.
Should be transitionDraws.
src/PrizePool.sol
Outdated
| uint256 winningRandomNumber_ | ||
| ) external onlyDrawManager returns (uint16) { | ||
| /// @return The ID of the closed draw | ||
| function transitionDraws(uint256 winningRandomNumber_) external onlyDrawManager returns (uint16) { |
There was a problem hiding this comment.
I'm not sure we should convey that this function also starts the next Draw, it's kinda implied.
I feel like completeDraw or awardDraw would be enough.
There was a problem hiding this comment.
Yeah I originally changed it to just closeDraw but I figured I should retain the message that was conveyed by the old name. I'll change it back to closeDraw.
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the language around the state of draws to be "Closed" and "Open" rather than "Completed" and "Next". The "current" draw is open, all others are closed. When we close the open draw and open the next, we "transition" draws.